Ignore test files on powerpc64* that's already ignored on powerpc #51237

infinity0 · 2018-05-31T04:08:24Z

The ignore-checker was made more strict recently so we now need more explicit ones

rust-lang#50989 The ignore-checker was made more strict recently so we now need more explicit ones

rust-highfive · 2018-05-31T05:00:54Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/a2/4f/d432270e1915a31e1eb4943e5080ca8e2e6a1908883d5de45ff4ac3c30a8/awscli-1.15.30-py2.py3-none-any.whl (1.3MB)
    0% |▎                               | 10kB 12.2MB/s eta 0:00:01
    1% |▌                               | 20kB 1.9MB/s eta 0:00:01
    2% |▉                               | 30kB 2.2MB/s eta 0:00:01
    3% |█                               | 40kB 2.0MB/s eta 0:00:01
---
    100% |████████████████████████████████| 1.3MB 995kB/s 
Collecting botocore==1.10.30 (from awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/da/aa/b227500e26dbbd95bd6cda78cf784f769bbad3e74b81bfc52963b55b6363/botocore-1.10.30-py2.py3-none-any.whl (4.3MB)
    0% |                                | 10kB 44.9MB/s eta 0:00:01
    0% |▏                               | 20kB 39.4MB/s eta 0:00:01
    0% |▎                               | 30kB 45.9MB/s eta 0:00:01
    0% |▎                               | 40kB 28.4MB/s eta 0:00:01
---
travis_time:start:test_ui
Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:47:06] 
[00:47:06] running 1480 tests
[00:47:10] ...........F.............................................................................i..........
[00:47:20] ....................................................................................................
[00:47:23] ....................................................................................................
[00:47:27] ....................................................................................................
[00:47:30] ....................................................................................................
---
[00:47:56] ......................................................................i.............................
[00:48:00] ....................................................................................................
[00:48:06] ....................................................................................................
[00:48:12] ....................................................................................................
:"/checkout/src/test/ui/asm-out-assign-imm.rs","byte_start":871,"byte_end":909,"line_start":32,"line_end":32,"column_start":9,"column_end":47,"is_primary":true,"text":[{"text":"        asm!(\"mov $1, $0\" : \"=r\"(x) : \"r\"(5));","highlight_start":9,"highlight_end":47}],"label":"cannot assign twice to immutable variable","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/asm-out-assign-imm.rs","byte_start":831,"byte_end":836,"line_start":29,"line_end":29,"column_start":5,"column_end":10,"is_primary":false,"text":[{"text":"    x = 1;","highlight_start":5,"highlight_end":10}],"label":"first assignment to `x`","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0384]: cannot assign twice to immutable variable `x`\n  --> /checkout/src/test/ui/asm-out-assign-imm.rs:32:9\n   |\nLL |     x = 1;\n   |     ----- first assignment to `x`\n...\nLL |         asm!(\"mov $1, $0\" : \"=r\"(x) : \"r\"(5));\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot assign twice to immutable variable\n\n"}
[00:48:16] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[00:48:16] {"message":"For more information about this error, try `rustc --explain E0384`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0384`.\n"}
[00:48:16] ------------------------------------------
[00:48:16] 
[00:48:16] thread '[ui] ui/asm-out-assign-imm.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3096:9
[00:48:16] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[00:48:16] test result: FAILED. 1465 passed; 1 failed; 14 ignored; 0 measured; 0 filtered out
[00:48:16] 
[00:48:16] 
[00:48:16] 
[00:48:16] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:48:16]

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

shepmaster · 2018-06-02T14:09:20Z

Thanks for the PR!

Doing a spot check with rg --files-without-match ignore-powerpc64 $(rg --files-with-matches 'ignore-powerpc'), I see these files:

src/test/codegen/stack-probes.rs
src/test/ui/asm-out-assign-imm.rs
src/test/ui/target-feature-wrong.rs
src/test/compile-fail/asm-in-bad-modifier.rs
src/test/compile-fail/asm-misplaced-option.rs
src/test/compile-fail/asm-out-read-uninit.rs
src/test/compile-fail/asm-out-no-modifier.rs
src/test/run-pass/stack-probes-lto.rs
src/test/run-pass/stack-probes.rs
src/test/compile-fail/borrowck/borrowck-asm.rs
src/test/compile-fail/asm-bad-clobber.rs

It seems this PR is missing a few of those, should it have them?

glaubitz · 2018-06-04T12:53:14Z

I don't think that any of the changes here should make the CI tests fail. Are you sure this isn't a different problem? Can someone retry?

shepmaster · 2018-06-04T13:37:34Z

We can retry when the review comments are addressed - no need to waste CI time until then.

shepmaster · 2018-06-04T13:39:21Z

However, if you read the messages, they are because the locations of error messages have changed in the modified files, so yes, this PR has broken those tests.

glaubitz · 2018-06-04T13:48:39Z

Sorry, I must be missing something here? All that @infinity0 did was adding some // ignore-powerpc64 to tests which fails on powerpc64*. Is there anything else that needs to be added?

shepmaster · 2018-06-04T14:01:31Z

the locations of error messages have changed in the modified files

I might have misread, let me investigate more.

shepmaster · 2018-06-04T15:18:42Z

The same error occurs when I run make check locally with this PR.

glaubitz · 2018-06-04T15:21:58Z

Hmm, ok. So, I assume this means adding // ignore-bla involves also modifying some other part to reflect those changes?

glaubitz · 2018-06-04T18:08:18Z

I am trying to understand the problem and just looked at other commits which set certain tests to ignore for mips*, i.e. 54467ae. And I don't anything different to what @infinity0 has done.

Has anything changed in this regard?

infinity0 · 2018-06-05T03:19:17Z

I will fix the line numbers tomorrow but I am not sure blanket-ignoring the other files is appropriate, since they didn't cause test failures that I could see.

As an aside I'm pretty annoyed that I even have to do this (and then getting told to do extra work on the PR to fix it), the original person who made this change really should be the one fixing it.

glaubitz · 2018-06-05T11:43:13Z

@infinity0 Fixing the .stderr files helps, see: #51343.

glaubitz · 2018-06-17T14:33:12Z

@infinity0 You can close this now, my fix in #51343 was merged.

infinity0 · 2018-06-17T16:23:42Z

Your PR was merged but it only takes care of sparc64 not powerpc64, sounds like this PR is still needed (and the line numbers need fixing up again?)

infinity0 · 2018-06-17T16:26:57Z

I just saw #51392 so closing.

Ignore test files on powerpc64* that's already ignored on powerpc, fixes

de8ee87

rust-lang#50989 The ignore-checker was made more strict recently so we now need more explicit ones

infinity0 changed the title ~~Ignore test files on powerpc64* that's already ignored on powerpc, fixes #50989~~ Ignore test files on powerpc64* that's already ignored on powerpc May 31, 2018

shepmaster self-assigned this Jun 2, 2018

shepmaster added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 2, 2018

glaubitz mentioned this pull request Jun 5, 2018

test: Ignore some problematic tests on sparc and sparc64 #51343

Merged

infinity0 closed this Jun 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ignore test files on powerpc64* that's already ignored on powerpc #51237

Ignore test files on powerpc64* that's already ignored on powerpc #51237

infinity0 commented May 31, 2018 •

edited

Loading

rust-highfive commented May 31, 2018

shepmaster commented Jun 2, 2018

glaubitz commented Jun 4, 2018

shepmaster commented Jun 4, 2018

shepmaster commented Jun 4, 2018

glaubitz commented Jun 4, 2018

shepmaster commented Jun 4, 2018

shepmaster commented Jun 4, 2018

glaubitz commented Jun 4, 2018

glaubitz commented Jun 4, 2018

infinity0 commented Jun 5, 2018

glaubitz commented Jun 5, 2018

glaubitz commented Jun 17, 2018

infinity0 commented Jun 17, 2018

infinity0 commented Jun 17, 2018

Ignore test files on powerpc64* that's already ignored on powerpc #51237

Ignore test files on powerpc64* that's already ignored on powerpc #51237

Conversation

infinity0 commented May 31, 2018 • edited Loading

rust-highfive commented May 31, 2018

shepmaster commented Jun 2, 2018

glaubitz commented Jun 4, 2018

shepmaster commented Jun 4, 2018

shepmaster commented Jun 4, 2018

glaubitz commented Jun 4, 2018

shepmaster commented Jun 4, 2018

shepmaster commented Jun 4, 2018

glaubitz commented Jun 4, 2018

glaubitz commented Jun 4, 2018

infinity0 commented Jun 5, 2018

glaubitz commented Jun 5, 2018

glaubitz commented Jun 17, 2018

infinity0 commented Jun 17, 2018

infinity0 commented Jun 17, 2018

infinity0 commented May 31, 2018 •

edited

Loading